More menu options #185
Closed
More menu options #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matrinox
commented
Jan 25, 2016
matrinox
commented
- Includes the PR from my fork: Fix bugs and add text override options to menu choices #184
- Adds colour options to menu choices (just a fun experiment, taking advantage of the flexibility of keyword args)
added 8 commits
January 24, 2016 18:35
By encapsulating menu items in a struct, it's easier to add more fields like text Instead of keeping name and text the same, they are now decoupled: user inputs match name while text is what's displayed in the terminal
…oice Originally, build_responses gave precedence to new hash (which makes sense) but then old hash was given precedence because it allowed the user to set things and let that stick Instead, the solution should be to split the concerns: one hash for user one hash for internal. The hashes are then merged when outputting, giving the user responses precedence This does have the side effect of taking away responses reflection on the side of the client but that is easily added in build_responses
You can use existing color options or color schemes defined in HighLine::ColorScheme
This simple hack removes implemenation knowledge and allows the client to construct the string they are used to
|
Are you planning to rebase this branch on top of the master branch? Or are we going to close this PR? |
|
I'll close it for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.