Adding support for non US-ASCII encoded menu items #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Eval the menu template in the interpreter's default_external encoding, which will probably be utf8, or something like windows-1252 on win32 - Added test with utf8 char in it
JEG2
added a commit
that referenced
this pull request
Mar 29, 2013
Adding support for non US-ASCII encoded menu items
|
Can we have a release please? :) |
|
1.6.19 was released on May 13. It includes this fix, doesn't it? |
|
Ah, sorry, I think I had two different encoding issues at the same time and only one of them was caused by me having an outdated highline. > 1.6.1 has not been tagged. Keep up the good work! |
|
I admit, I'm terrible about forgetting to tag releases. We'll need to get someone to locate the proper SHA's so I can add the tags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which will probably be utf8, or something like windows-1252 on win32