Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new Control object #74

Closed
wants to merge 1 commit into from
Closed

Added new Control object #74

wants to merge 1 commit into from

Conversation

maxbisesi
Copy link
Member

The allsphere is a great center piece for a gui, it is the all capable
interface for a user to interact with their application

The allsphere is a great center piece for gui, it is the all capable
interface for a user to interact with their application
@tbee
Copy link
Member

tbee commented Nov 16, 2016

There is no decent Javadoc describing what it does and how to use it, there is no test validating its behavior. This pull request belongs in JFXtras-labs.

@tbee tbee closed this Nov 16, 2016
@maxbisesi
Copy link
Member Author

tbee,
Sorry this was my first pr. Trying to learn and contribute!
What should I do in the future? Create a javadoc and create a test file?
I appreciate any help

@tbee
Copy link
Member

tbee commented Nov 16, 2016

We have JFXtras-labs, which is a place where new controls can mature. I'm currently working on ResponsiveLayout and it too first lives in that project until it is mature, the API is stable, Javadoc is in place and a number of TestFX tests are written to validate the behavior. Then the control moves to any of the artifacts that JFXtras consists of.

If you want to add something to JFXtras, and we would really appreciate that, you have to fill out the CLA
http://steveonjava.com/forms/jfxtras-individual-cla-v1-0/

and that will give you write access to the labs project. Then you can check in the control and we can let it grow there until it is ready.

@tbee
Copy link
Member

tbee commented Nov 17, 2016

You've been added to the labs project, you can check it out and add your control there.

@maxbisesi
Copy link
Member Author

Thanks!

On Thu, Nov 17, 2016 at 5:35 AM, Tom Eugelink notifications@github.com
wrote:

You've been added to the labs project, you can check it out and add your
control there.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#74 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AVV3rGMyNsrx-6pqo1Og3lx_5ulweIXFks5q_DvqgaJpZM4K0BSb
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants