Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlapping file check is incorrect #114

Closed
bpbond opened this issue Jan 5, 2015 · 2 comments
Closed

Overlapping file check is incorrect #114

bpbond opened this issue Jan 5, 2015 · 2 comments
Assignees
@bpbond
Labels
bug

Comments

@bpbond
Copy link
Member

bpbond commented Jan 5, 2015

loadEnsemble registers the following files register as overlapping, but they're not:

tas_Amon_CMCC-CMS_historical_r1i1p1_185001-185912.nc
tas_Amon_CMCC-CMS_historical_r1i1p1_186001-186912.nc

Thanks @amundra
@bpbond bpbond added the bug label Jan 5, 2015
@bpbond bpbond self-assigned this Jan 5, 2015
bpbond added a commit that referenced this issue Jan 5, 2015
@bpbond
Fixed incorrect overlap test
1688717 
Fixes issue #114.
@bpbond
Copy link
Member Author

bpbond commented Jan 5, 2015

This is fixed in commit 1688717. Leaving issue open because I want to write test code for this.

bpbond added a commit that referenced this issue Jan 5, 2015
@bpbond
Test code for issue #114
abd29c2
@bpbond
Copy link
Member Author

bpbond commented Jan 5, 2015

Test code for this added in commit abd29c2. Also this issue exposed two bugs in saveNetCDF, which was writing incorrect time data.

@bpbond bpbond closed this as completed Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpbond bpbond

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bpbond