Add Latin hypercube sampling #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed for reproducibility
bpbond
reviewed
Jun 4, 2020
R/main.R
Outdated
| @@ -33,6 +33,8 @@ | |||
| #' @param aType Scenario type: either "Reference" or "Hindcast" | |||
| #' @param aIncludeSubsidies Boolean indicating subsidies should be added to profit | |||
| #' @param aDifferentiateParamByCrop Boolean indicating whether all crops should use the same expectation parameters | |||
| #' @param aUseLatinHypercube Boolean indicating that Latin Hypercube Sampling should be used (if FALSE, sobol sequences will be used) | |||
There was a problem hiding this comment.
Butting in on your PR, sorry. Would a better long term design be sampling_type = c("latin_hypercube", "sobol")? I.e. if you wanted to allow for more options down the road?
dplyr causes problems when run in the package checks, so remove the dependence.
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
- Coverage 88.59% 88.58% -0.02%
==========================================
Files 22 22
Lines 1666 1664 -2
==========================================
- Hits 1476 1474 -2
Misses 190 190
Continue to review full report at Codecov.
|
abigailsnyder
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide two options for sampling: latin hypercube and Sobol. Also, updates limits on parameter values.