Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate the template ini file. #3

Merged
merged 5 commits into from
Apr 22, 2020
Merged

Generate the template ini file. #3

merged 5 commits into from
Apr 22, 2020

Conversation

kdorheim
Copy link
Collaborator

@kdorheim kdorheim commented Apr 22, 2020

This PR merges the materials to create and test a template ini file. The scenario name has been removed from one of the CMIP5 RCP ini files and replaced with the tag TEMPLATE. This PR is also a text to make sure that the github workflows are set up properly.

@kdorheim
Copy link
Collaborator Author

@bpbond I am stumped why the test-coverage is still failing, does it have to do with how the git hub actions sets were set up? do you have time to take a look at it?

@bpbond
Copy link
Member

bpbond commented Apr 22, 2020

Yes will do

@bpbond
Copy link
Member

bpbond commented Apr 22, 2020

There are no tests! So no package coverage can be calculated. I think that's the problem.

@bpbond
Copy link
Member

bpbond commented Apr 22, 2020

Whoops I pushed sample test to master by accident, sorry

@bpbond
Copy link
Member

bpbond commented Apr 22, 2020

That wasn't it, although the sample test I added doesn't actually test any code. Maybe just delete the coverage test for now, until you have code to test?

@kdorheim
Copy link
Collaborator Author

interesting, okay I will remove the test for now!

@kdorheim kdorheim merged commit 42f01d8 into master Apr 22, 2020
@kdorheim kdorheim deleted the default_ini_template branch April 22, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants