Bugfix/xquery empty regions #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
region list, which should indicate query all regions, was causing an error for XQuery style queries. This closes #16.
rplzzz
approved these changes
May 31, 2017
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
=======================================
Coverage 92.15% 92.15%
=======================================
Files 5 5
Lines 446 446
=======================================
Hits 411 411
Misses 35 35 |
|
Not sure why this didn't close automatically on merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #16. The fix was really in the model interface and was pretty straight forward but it shows up here as just a new version of the
ModelInterface.jar. Note I also added a test case to ensure this issue doesn't reappear.