Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Java max memory #68

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Configurable Java max memory #68

merged 2 commits into from
Nov 19, 2019

Conversation

pralitp
Copy link
Contributor

@pralitp pralitp commented Nov 15, 2019

Make the maximum Java heap size for localDBConn an explicit argument as depending on users Java installation / use case the appropriate value may vary.

This closes #64

depending on users Java installation / use case the appropriate value
may vary.

This closes #64
@pralitp pralitp requested a review from rplzzz November 15, 2019 16:32
@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
R/querymi.R 84.95% <100%> (ø) ⬆️

Copy link
Contributor

@rplzzz rplzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid. I've incremented the version to 1.1.0, since we've added a new feature.

@rplzzz
Copy link
Contributor

rplzzz commented Nov 19, 2019

@pralitp Are we good with merging this, or are you still working on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory limits blocking ability to connect to database
2 participants