JITX-5813/revert-esir-changes #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwin-lau
requested review from
CuppoJava,
bhusang,
PhilippeFerreiraDeSousa and
AashnaP22
JITX-5813 Add 3D models to "Create component"
When the user clicks "Create component":
When a user exports to Kicad, they should be able to see the 3d models rendered. |
AashnaP22
approved these changes
Aug 23, 2023
utils/parts.stanza
Outdated
| @@ -1003,7 +1010,7 @@ defn to-jitx (lp: LandPatternCode, jitx-pads-by-pcb-pad-name: HashTable<String, | |||
|
|
|||
| do(to-jitx, layers(lp)) | |||
| do(to-jitx, geometries(lp)) | |||
| do(to-jitx, model3ds(lp)) | |||
| do(to-jitx{model3d(_)}, model3ds(lp)) | |||
There was a problem hiding this comment.
I actually added function composition to lang-utils 4 months ago to allow for do(to-jitx * model3d, model3ds(lp))
There was a problem hiding this comment.
There was a problem hiding this comment.
You got me
PhilippeFerreiraDeSousa
approved these changes
Aug 23, 2023
bhusang
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
parts-db-collection="test-pat"Note