Antenna.js full translated from Matlab #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preceding file in the repo had some non-working code, not still translated from Matlab. The version I propose is a full translation of functions antennafunccircular, array_factorcir and trapezoidalcir, found here: http://www3.ntu.edu.sg/home/epnsugan/index_files/CEC11-RWP/CEC11-RWP.htm I have tested it with several inputs and the results are the same than the produced by the original functions. However, a more extensive test is mandatory. It also remains to add the license and the corresponding credits and a deep format revision.
| break; | ||
| } | ||
| tem=yax[phi_ref-i]; | ||
| if (yax[phi_ref-i]<yax[phi_ref-i-1] && yax[phi_ref-i]<yax[phi_ref-i+1]) { |
There was a problem hiding this comment.
Identifier 'phi_ref' is not in camel case.
Too many errors. (80% scanned).
|
I said a deep format revision was needed haha. |
JJ
added a commit
that referenced
this pull request
Oct 24, 2015
Antenna.js full translated from Matlab Anything translated from matlab is good!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preceding file in the repo had some non-working code, not still translated from Matlab. The version I propose is a full translation of functions antennafunccircular, array_factorcir and trapezoidalcir, found here:
http://www3.ntu.edu.sg/home/epnsugan/index_files/CEC11-RWP/CEC11-RWP.htm
I have tested it with several inputs and the results are the same than the produced by the original functions. However, a more extensive test is mandatory. It also remains to add the license and the corresponding credits and a deep format revision.