Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MANIFEST.in to include sibc/data #9

Merged
merged 1 commit into from
Oct 9, 2021
Merged

Add MANIFEST.in to include sibc/data #9

merged 1 commit into from
Oct 9, 2021

Conversation

calesanz
Copy link
Contributor

@calesanz calesanz commented Oct 9, 2021

This patch introduces a MANIFEST.in file. This is used in source distributions.
When installing sibc on archlinux using python setup.py install --user the data directory is omitted.

Without the data the program crashes immediately.

This can be fixed by specifying the path in the MANIFEST.in file.

When installing sibc on archlinux using
`python setup.py install --user` the
data directory is omitted.

This can be fixed by specifying the path
in the MANIFEST.in file.
@JJChiDguez
Copy link
Owner

Thanks for catching it! It is tricky to handle all Linux distros!
We have checked it, and we are going to merge it
Thanks!

@JJChiDguez JJChiDguez merged commit ef07ca4 into JJChiDguez:master Oct 9, 2021
@calesanz
Copy link
Contributor Author

calesanz commented Oct 9, 2021

Thanks that was quick 👍 🥇

@calesanz calesanz deleted the source-install branch October 9, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants