Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make icons more flexible #428

Merged
merged 2 commits into from
May 18, 2022
Merged

Make icons more flexible #428

merged 2 commits into from
May 18, 2022

Conversation

ChrissW-R1
Copy link
Contributor

If you have more than one map per world with the same type, you have to use different names as identifiers.

Default maps for overworld: flat, surface and cave
Multiple maps with different perspectives: flat, surface_se, surface_sw, surface_nw, surface_ne, cave_se, cave_sw, cave_nw and cave_ne

The SVG icons will defined by the map name. In this case maps like surface_se will not detected as surface. This pull request changes the detection to the first part of the name. The name will split on every non-alphanumeric character.

We use this on our servers. Here some example: https://map.julieka.community

@JLyne JLyne merged commit e3070c9 into JLyne:master May 18, 2022
@JLyne
Copy link
Owner

JLyne commented May 18, 2022

Looks good, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants