Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addAll() now returns a promise #7

Merged
merged 4 commits into from
Oct 21, 2016
Merged

addAll() now returns a promise #7

merged 4 commits into from
Oct 21, 2016

Conversation

mawrkus
Copy link
Contributor

@mawrkus mawrkus commented Oct 21, 2016

No description provided.

@mawrkus
Copy link
Contributor Author

mawrkus commented Oct 21, 2016

Fixes #6. On my way, I took the opportunity to refactor the unit tests. Let me know what you think.

@mawrkus mawrkus changed the title AddAllnow returns a promise addAll now returns a promise Oct 21, 2016
@mawrkus mawrkus changed the title addAll now returns a promise addAll() now returns a promise Oct 21, 2016
@JMPerez
Copy link
Owner

JMPerez commented Oct 21, 2016

👍

@JMPerez JMPerez merged commit 6a9eec2 into JMPerez:master Oct 21, 2016
@JMPerez JMPerez mentioned this pull request Oct 22, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mawrkus @JMPerez