Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add(All) parameter type #83

Merged
merged 1 commit into from
Sep 13, 2020
Merged

Fix add(All) parameter type #83

merged 1 commit into from
Sep 13, 2020

Conversation

draperunner
Copy link
Contributor

add and addAll don't take Promise directly, but a function that once called returns a promise

@draperunner
Fix add(All) parameter type
0843fdf 
add and addAll don't take Promise directly, but a function that once called returns a promise
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0843fdf on draperunner:typescript-fix into 4395ff7 on JMPerez:master.

@JMPerez
Copy link
Owner

JMPerez commented Sep 13, 2020

Fixes #79

@JMPerez JMPerez merged commit a96e86a into JMPerez:master Sep 13, 2020
@JMPerez
Copy link
Owner

JMPerez commented Sep 13, 2020

Thank you @draperunner!

@draperunner draperunner deleted the typescript-fix branch September 14, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@draperunner @coveralls @JMPerez