New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayoutEditor: findbug fixes #4430

Merged
merged 97 commits into from Nov 20, 2017

Conversation

Projects
5 participants
@geowar1
Contributor

geowar1 commented Nov 18, 2017

No description provided.

pabender and others added some commits Oct 4, 2017

pabender and others added some commits Nov 17, 2017

make a method that should be static static; deprecate duplicate insta…
…nce of the same method in another class.
Merge pull request #4410 from pabender/master
Create generic consist managers associated with each system.

@bobjacobsen bobjacobsen changed the base branch from master to LayoutEditor-development Nov 19, 2017

@bobjacobsen

This comment has been minimized.

Member

bobjacobsen commented Nov 19, 2017

Moved to referenced LayoutEditor-development branch and CI restarted.

geowar1 added some commits Nov 19, 2017

@bobjacobsen

This comment has been minimized.

Member

bobjacobsen commented Nov 19, 2017

Travis graphical passed, but headless failed and was restarted:

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.011 s <<< FAILURE! - in jmri.jmrit.display.layoutEditor.blockRoutingTable.LayoutBlockRouteTableActionTest
[ERROR] testCTor(jmri.jmrit.display.layoutEditor.blockRoutingTable.LayoutBlockRouteTableActionTest)  Time elapsed: 0.011 s  <<< ERROR!
java.awt.HeadlessException
	at java.awt.GraphicsEnvironment.checkHeadless(GraphicsEnvironment.java:204)
	at java.awt.Window.<init>(Window.java:536)
	at java.awt.Frame.<init>(Frame.java:420)
	at java.awt.Frame.<init>(Frame.java:385)
	at javax.swing.JFrame.<init>(JFrame.java:189)
	at jmri.util.JmriJFrame.<init>(JmriJFrame.java:83)
	at jmri.util.JmriJFrame.<init>(JmriJFrame.java:124)
	at jmri.jmrit.display.layoutEditor.blockRoutingTable.LayoutBlockRouteTableAction.<init>(LayoutBlockRouteTableAction.java:37)
	at jmri.jmrit.display.layoutEditor.blockRoutingTable.LayoutBlockRouteTableActionTest.testCTor(LayoutBlockRouteTableActionTest.java:19)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
@bobjacobsen

This comment has been minimized.

Member

bobjacobsen commented Nov 19, 2017

Same error on Travis headless as above. Looks like there's a test running in headless mode that attempts to open a window.

[ERROR] testCTor(jmri.jmrit.display.layoutEditor.blockRoutingTable.LayoutBlockRouteTableActionTest)  Time elapsed: 0.014 s  <<< ERROR!
java.awt.HeadlessException
	at java.awt.GraphicsEnvironment.checkHeadless(GraphicsEnvironment.java:204)
	at java.awt.Window.<init>(Window.java:536)
	at java.awt.Frame.<init>(Frame.java:420)
	at java.awt.Frame.<init>(Frame.java:385)
	at javax.swing.JFrame.<init>(JFrame.java:189)
	at jmri.util.JmriJFrame.<init>(JmriJFrame.java:83)
	at jmri.util.JmriJFrame.<init>(JmriJFrame.java:124)
	at jmri.jmrit.display.layoutEditor.blockRoutingTable.LayoutBlockRouteTableAction.<init>(LayoutBlockRouteTableAction.java:37)
	at jmri.jmrit.display.layoutEditor.blockRoutingTable.LayoutBlockRouteTableActionTest.testCTor(LayoutBlockRouteTableActionTest.java:19)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
Add "Assume headless" to LayoutBlockRouteTableActionTest
If this passes all checks please assign and merge…

@geowar1 geowar1 changed the title from Layout editor findbug fixes to LayoutEditor: findbug fixes Nov 20, 2017

@bobjacobsen bobjacobsen merged commit 18311d3 into JMRI:LayoutEditor-development Nov 20, 2017

4 checks passed

WIP ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.06%) to 38.791%
Details

@geowar1 geowar1 deleted the geowar1:LayoutEditor-Findbug-fixes branch Nov 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment