210 review helpfile #213
210 review helpfile #213
Conversation
|
@Constantino-Carreto-Romero can you please read these helpfiles again to see if everything is clear and if you spot any mistakes? |
|
|
||
| {marker imputetype}{...} | ||
| {phang} | ||
| {opt impute(type, [ saveimp])} imputes missing values in {it:policyvar} and uses this new variable as the actual {it:policyvar}. | ||
| {opt impute(type, [ saveimp])} imputes leads, lags, and missing values of {it:policyvar} and uses this new variable as the actual {it:policyvar}. |
There was a problem hiding this comment.
@jorpppp
What do you think of adding here in the impute section a suggestion for the user to check the impute note?
There was a problem hiding this comment.
Good idea, can you implement please @Constantino-Carreto-Romero ?
Also please edit the impute note to make the language consistent: "imputes leads, lags and missing values of the policy variable".
There was a problem hiding this comment.
implemented in d293178
There was a problem hiding this comment.
Thanks, don't forget to edit the impute note too (we should do it in this PR).
| @@ -293,20 +314,17 @@ the cohort variable. {opt save} adds the new control cohort variable to the data | |||
| is not specified. | |||
There was a problem hiding this comment.
A minor clarification, I think we could change it to:
"{opt control_cohort(create)} is the default if {opt cohort(create)} is specified but {opt control_cohort} is not specified."
There was a problem hiding this comment.
Thanks, agreed, please implement @Constantino-Carreto-Romero
There was a problem hiding this comment.
changed in ebb8939
This reverts commit 824b616.
|
Thanks @Constantino-Carreto-Romero . I deleted the issue folder, merging now. |
* #210 Changes to xtevent helpfile, enable abbreviations * #210 Changes to other helpfiles * #214 Change ci default style to p1 (#215) (#216) * #210 add link to impute note * #210 minor edit * #210 minor edit to acknowledgements * #210 minor clarification * #210 update description of impute * "#210 revert previous commit" This reverts commit 824b616. * #210 update impute note * #210 revert minor unintended changes * #210 docs to create impute note * #210 #213 Delete issue folder --------- Co-authored-by: Constantino Carreto Romero <carretoromeroc@gmail.com>
* #217 Test adding more results to repost * 210 review helpfile (#213) (#218) * #210 Changes to xtevent helpfile, enable abbreviations * #210 Changes to other helpfiles * #214 Change ci default style to p1 (#215) (#216) * #210 add link to impute note * #210 minor edit * #210 minor edit to acknowledgements * #210 minor clarification * #210 update description of impute * "#210 revert previous commit" This reverts commit 824b616. * #210 update impute note * #210 revert minor unintended changes * #210 docs to create impute note * #210 #213 Delete issue folder --------- Co-authored-by: Constantino Carreto Romero <carretoromeroc@gmail.com> * #217 post est results from interacted regression * #217 original test file output * #217 test file output after changes to eventols * #217 SA and trend adjustment by GMM * #217 test file after edits to eventols * #217 return b and V from the interacted regression * #217 add to help about b and V from interacted reg * #217 updated log file --------- Co-authored-by: Constantino Carreto Romero <carretoromeroc@gmail.com>
Closes #210