Blend Wikidata item name in properties table with background #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of always using the same color Fixes #21752.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of always using the same color
Fixes #21752.
Before:
After:
This fix doesn't change a lot of code, but due to that it may not really be optimal. Since the original code uses Swing's HTML rendering support to change the color, this fix uses the same approach to not completely change everything. Blend ratio between foreground and background is 50/50, so effectively the foreground for the item name now has 50 % opacity. One could perhaps play around a bit more with that ratio, although 75 % opacity was too close to completely opaque in my eyes, while the current result may still be considered too light.