Fixup tests #9
Merged
Fixup tests #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taylor Smock <tsmock@fb.com>
tsmock
force-pushed
the
fixup-tests
branch
9 times, most recently
from
5abecfb
to
288691f
Compare
Signed-off-by: Taylor Smock <tsmock@fb.com>
Signed-off-by: Taylor Smock <tsmock@fb.com>
Signed-off-by: Taylor Smock <tsmock@fb.com>
|
Werps. I've been fiddling with the workflow a bit. I should have changed this to a draft PR. (see 9e8f607). |
|
Sorry, but apart from that it looked pretty much ready. And it looks like it works so far, so I guess I'll revert 9e8f607 but leave the rest. |
|
I had been pushing a known bad version to check and make certain that the EDIT: NVM, it looks like you fixed the failing tests already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a github workflow, building off of the one I made for the Lanes plugin.
See https://github.com/tsmock/wikipedia/actions/runs/2625888938 for a release run, and https://github.com/tsmock/wikipedia/releases/tag/v1.2.1-test3 for the test release.