Double Agent improvements #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only reason I'm hesitating to approve this, is that it's changing a domain class, Character. |
|
Hmm, see what you mean. I’ll do some more testing....
Jon
…________________________________
From: Dave Spring ***@***.***>
Sent: Wednesday, November 1, 2023 12:22:26 PM
To: JOverseer/joverseer ***@***.***>
Cc: Jon Steer ***@***.***>; Author ***@***.***>
Subject: Re: [JOverseer/joverseer] Double Agent improvements (PR #744)
The only reason I'm hesitating to approve this, is that it's changing a domain class, Character.
The .jov file is basically default java object serialization with some explicit SerializationIds. So we get compatibility issues to consider and address when classes change.
Will previous versions of JO read .jov files created by the new version, without complaint, and will new JO read old .jov files with sensible defaults?
—
Reply to this email directly, view it on GitHub<#744 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAC4IVLIBAQ5NTKVQS5BRQDYCI5IFAVCNFSM6AAAAAA6HJ5NT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYHA3DIMJUHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Hi Dave,
I’ve tested opening and saving in different versions and haven’t seen any issues. Obviously, the new functionality only shows up if you re-import at least the latest turn as it is during the import that characters are flagged as double agents. Re-importing with new version then saving and loading in current version works fine. Saving in old version and opening again in new version also works fine, although the double-agent flag is lost so re-import is needed to get them flagged again.
Cheers
Jon
From: Jon Steer ***@***.***>
Date: Wednesday, 1 November 2023 at 16:40
To: JOverseer/joverseer ***@***.***>, JOverseer/joverseer ***@***.***>
Cc: Author ***@***.***>
Subject: Re: [JOverseer/joverseer] Double Agent improvements (PR #744)
Hmm, see what you mean. I’ll do some more testing....
Jon
…________________________________
From: Dave Spring ***@***.***>
Sent: Wednesday, November 1, 2023 12:22:26 PM
To: JOverseer/joverseer ***@***.***>
Cc: Jon Steer ***@***.***>; Author ***@***.***>
Subject: Re: [JOverseer/joverseer] Double Agent improvements (PR #744)
The only reason I'm hesitating to approve this, is that it's changing a domain class, Character.
The .jov file is basically default java object serialization with some explicit SerializationIds. So we get compatibility issues to consider and address when classes change.
Will previous versions of JO read .jov files created by the new version, without complaint, and will new JO read old .jov files with sensible defaults?
—
Reply to this email directly, view it on GitHub<#744 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAC4IVLIBAQ5NTKVQS5BRQDYCI5IFAVCNFSM6AAAAAA6HJ5NT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBYHA3DIMJUHA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a double agent flag to character model. Allows tracking of double agents even when they belong to an ally. Add filter to advanced char view.