-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing and generation of dictionaries #438
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSAbrahams
added
enhancement: check
New feature in the type check module
enhancement: parse
New feature in the parse module
labels
Jan 8, 2023
Codecov Report
@@ Coverage Diff @@
## develop #438 +/- ##
===========================================
+ Coverage 88.16% 88.17% +0.01%
===========================================
Files 105 105
Lines 11391 11497 +106
===========================================
+ Hits 10043 10138 +95
- Misses 1348 1359 +11
|
JSAbrahams
changed the title
Add parsing and generation of dictionaries
Parsing and generation of dictionaries
Jan 9, 2023
JSAbrahams
commented
Jan 10, 2023
Up next: sad tests to verify check implementation.
We also added a test for a slightly more complex generation of dictionary calls. We want to change the behaviour in Mamba such that access of a dictionary gives an `Optional`, with no chance of a `KeyError` being thrown.
JSAbrahams
force-pushed
the
dictionaries
branch
from
January 17, 2023 20:41
e9bcc67
to
7717d4d
Compare
JSAbrahams
commented
Jan 17, 2023
JSAbrahams
commented
Jan 17, 2023
JSAbrahams
commented
Jan 17, 2023
tests/resource/valid/collection/dictionary_return_is_optional_check.py
Outdated
Show resolved
Hide resolved
Closed
2 tasks
JSAbrahams
commented
Jan 21, 2023
Merged
JSAbrahams
added a commit
that referenced
this pull request
Jan 21, 2023
* Add parsing and generation of dictionaries * Implement dictionary builder * Use __getitem__ for index instead of iterator * Add dictionary keys() and values() iters * Verify set not indexable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement: check
New feature in the type check module
enhancement: generate
New feature in the core module
enhancement: parse
New feature in the parse module
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issues
Expect
andName
#439Summary
keys()
method which returns iterator where__next__()
has key return typevalues()
method which returns iterator where__next__()
has value return typeAdded Tests
Happy
Sad