Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide mode flag to ResetToInitialConditions() to skip the execution of RunIC() #466

Merged
merged 3 commits into from
Jul 10, 2021
Merged

Provide mode flag to ResetToInitialConditions() to skip the execution of RunIC() #466

merged 3 commits into from
Jul 10, 2021

Conversation

seanmcleod
Copy link
Member

@seanmcleod seanmcleod mentioned this pull request Jul 6, 2021
Closed
bcoconni
bcoconni requested changes Jul 7, 2021
View reviewed changes
Copy link
Member

@bcoconni bcoconni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I suggest to move the constants to the header FGFDMExec.h where they could be documented and therefore easier to get for someone looking for guidance about how to use FGFDMExec::ResetToInitialConditions.

src/FGFDMExec.cpp Outdated Show resolved Hide resolved
seanmcleod and others added 2 commits July 8, 2021 10:11
@seanmcleod @bcoconni
Move constants to header file
122caeb 
Co-authored-by: Bertrand Coconnier <bcoconni@users.noreply.github.com>
@seanmcleod
Document mode flags for ResetToInitialConditions()
614214c
@seanmcleod
Copy link
Member Author

@bcoconni I was in a bit of a rush originally. I've moved the constants to the header file and added some documentation in the latest commit.

bcoconni
bcoconni approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@bcoconni bcoconni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the code.

@bcoconni bcoconni merged commit a65947f into JSBSim-Team:master Jul 10, 2021
bcoconni pushed a commit that referenced this pull request Jul 10, 2021
@seanmcleod @bcoconni
Provide mode flag to ResetToInitialConditions() to skip the execution…
14beeb7 
… of RunIC() (#466)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcoconni bcoconni bcoconni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seanmcleod @bcoconni