Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest versions are not CommonJS compatible #17

Closed
lancedikson opened this issue Aug 13, 2020 · 2 comments
Closed

Latest versions are not CommonJS compatible #17

lancedikson opened this issue Aug 13, 2020 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@lancedikson
Copy link

lancedikson commented Aug 13, 2020

Hi again 😄 My applications are failing now as the latest released versions of @sweet-monads are not CommonJS-compatible for some reason. You might have changed something in the compilation settings? The 2.0.0 version is compatible and the later ones are already not:

// 2.0.0 exports
exports["default"] = MaybeConstructor;
exports.merge = MaybeConstructor.merge, exports.just = MaybeConstructor.just, exports.none = MaybeConstructor.none, exports.from = MaybeConstructor.from;
exports.isMaybe = function (value) {
    return value instanceof MaybeConstructor;
};
// 2.1.2 export
export default class MaybeConstructor {
    constructor(type, value) {

So, Node 12 (which is LTS still) fails to run such apps. Should we consider it as a bug or it's something that meant to happen? :)

@JSMonk
Copy link
Owner

JSMonk commented Aug 13, 2020

Oh, will fix it soon. Thank you a lot.

@JSMonk
Copy link
Owner

JSMonk commented Aug 14, 2020

Done in 2.1.4

@JSMonk JSMonk added the bug Something isn't working label Aug 14, 2020
@JSMonk JSMonk self-assigned this Aug 14, 2020
@JSMonk JSMonk closed this as completed Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants