Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(waybar): fix cava creating multiple instances #132

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

momcilovicluka
Copy link
Contributor

Pull Request

Description

WaybarCava was creating a new instance of cava every time it was executed. This happens when waybar is restarted/wallpaper is changed

Fixed by killing cava process referencing the same config

Fix: #131

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I want to add something in Hyprland-Dots wiki.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

(if appropriate)

Additional context

Add any other context about the problem here.

WaybarCava was creating a new instance of cava every time it was
executed. This happens when waybar is restarted/wallpaper is changed

Fixed by killing cava process referencing the same config

Fix: JaKooLit#131
@JaKooLit JaKooLit added the bug Something isn't working label Jan 8, 2024
@JaKooLit JaKooLit merged commit cec16f1 into JaKooLit:development Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants