Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improvement to brightness script #313

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

jmsapt
Copy link

@jmsapt jmsapt commented May 29, 2024

Pull Request

Description

Brightness.sh was not using the -n/--min-value flag for brightnessctl. This was causing the raw brightness value to reach 0 if you kept decreasing brightness, leaving a completly black screen.

Adding this flag leaves the brightness at raw value 1 (minimum possible brightness for screen to be readable), instead of letting it reach 0.

Type of change

Please put an x in the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (non-breaking change; modified files are limited to the documentations)
  • Technical debt (a code change that does not fix a bug or add a feature but makes something clearer for devs)
  • Other (provide details below)

Checklist

Please put an x in the boxes that apply:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit message follows the commit guidelines.
  • My change requires a change to the documentation.
  • I want to add something in Hyprland-Dots wiki.
  • I have added tests to cover my changes.
  • I have tested my code locally and it works as expected.
  • All new and existing tests passed.

Screenshots

N/A

Additional context

N/A

@JaKooLit JaKooLit changed the base branch from main to development May 29, 2024 17:42
@JaKooLit
Copy link
Owner

Cool..

Thanks

@JaKooLit JaKooLit merged commit cfdd7e9 into JaKooLit:development May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants