Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom export filter cannot be used #4013

Closed
1 task done
alick opened this issue May 6, 2018 · 9 comments
Closed
1 task done

custom export filter cannot be used #4013

alick opened this issue May 6, 2018 · 9 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs export / save

Comments

@alick
Copy link
Contributor

alick commented May 6, 2018

JabRef version 4.2+ on Fedora 27

Steps to reproduce:

  1. Add a custom export filter https://github.com/alick/jabref-export/tree/master/listrefs with the name 'test'
  2. Export a selected bib entry
  3. In the save file dialog, look for the custom filter entry in the popdown filter list.
  4. There are two 'HTML list file (*.html)' entries in the popdown list. Neither gives the custom result. No entry for 'test'.

screenshot from 2018-05-05 21-51-15
screenshot from 2018-05-05 22-00-05

Notes:

  • I think I might have filename clash with shipped filter. But after I changed my custom one to a new name, the result is still the same.
  • With JabRef 4.1, the 'test' filter appears in the popdown list, but with a wrong suffix (DEFAULT) although it is .html in the 'Manage custom export' dialog.
@Siedlerchr
Copy link
Member

There is a version that should fix this at https://builds.jabref.org/fixCustomExportFileType/ Please try it out.

@Siedlerchr Siedlerchr added status: waiting-for-feedback The submitter or other users need to provide more information about the issue export / save bug Confirmed bugs or reports that are very likely to be bugs labels May 6, 2018
@alick
Copy link
Contributor Author

alick commented May 6, 2018 via email

@Siedlerchr
Copy link
Member

Thanks for the feedback, I could reproduce that and I think I found a way to fix this. At least my tests were succesful. Could you please try the updated version here? https://builds.jabref.org/fixCustomExportFileType/
The current version contains the commit id 1a0cde3 in the version number

@alick
Copy link
Contributor Author

alick commented May 7, 2018

@Siedlerchr It is fixed. Yay! Thanks a lot.

@drmikewest
Copy link

I have been monitoring this issue since it arose in v4.1 (I am a longtime use, not developer, and we use the custom export routinely). I've tested the posted 4.3 dev snapshop version and confirm that - for me after a series of tests - it is working fine.

@alick
Copy link
Contributor Author

alick commented May 12, 2018

I'll close the issue for now. Please help get the fix merged to new release :)

@alick alick closed this as completed May 12, 2018
@Siedlerchr
Copy link
Member

Please leave the issue open as long as the fix is not yet merged in master. The issue will be auto closed after merge.

@Siedlerchr Siedlerchr added fixed-in-devBuilds and removed status: waiting-for-feedback The submitter or other users need to provide more information about the issue labels May 12, 2018
@alick alick reopened this May 12, 2018
@lc9275
Copy link

lc9275 commented Jun 1, 2018

Will this version be merged with master? After updating to 4.2, none of our custom export filters were showing up. This patch seems to fix it.

@Siedlerchr
Copy link
Member

The version will soon be merged with master. The latest version of the branch already is based on master. Just some minor internal code changes and the PR will be merged. See the PR for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs export / save
Projects
None yet
Development

No branches or pull requests

4 participants