Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discrete versus integrated graphics card on MacOS #4070

Closed
jcrbloch opened this issue Jun 1, 2018 · 4 comments
Closed

discrete versus integrated graphics card on MacOS #4070

jcrbloch opened this issue Jun 1, 2018 · 4 comments

Comments

@jcrbloch
Copy link

jcrbloch commented Jun 1, 2018

When starting jabref on MacOS the system automatically changes from the integrated to the discrete graphics card. This is not necessary and is due to the following incorrect key in the Info.plist in jabref 4.2:

<key>NSSupportsAutomaticGraphicsSwitching</key>
<string>YES</string>

which should in fact be:

<key>NSSupportsAutomaticGraphicsSwitching</key>
<true/>

This is also documented here:
https://developer.apple.com/library/content/qa/qa1734/_index.html

@stefan-kolb
Copy link
Member

@JabRef/developers Does anyone remember why we included thi switch? I think it was related to some graphics problem on macOS.

@jcrbloch
Copy link
Author

jcrbloch commented Jun 2, 2018

In an older issue from 16Jan2017 it seemed to have been proposed to solve exactly this problem, See #2470.

It may be that Apple modified the switch since then, so that the old solution no longer works. I tried both possibilities in the plist and only my new suggestion works for me. This is also what is stated in Apple's documentation.

@stefan-kolb
Copy link
Member

So do we really need the new switch or is there no problem anymore even if we remove the switch?

@jcrbloch
Copy link
Author

jcrbloch commented Jun 2, 2018

I just tried removing the switch, but then the problem reappears. The new switch is thus absolutely necessary.

stefan-kolb added a commit that referenced this issue Jun 2, 2018
stefan-kolb added a commit that referenced this issue Jun 2, 2018
stefan-kolb added a commit that referenced this issue Jun 7, 2018
* Resolves #4070 Mac graphics
stefan-kolb added a commit that referenced this issue Jun 7, 2018
* Resolves #4070 Mac graphics

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants