Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve check for page numbers #4113

Closed
bernhard-kleine opened this issue Jun 7, 2018 · 5 comments · Fixed by #4498
Closed

Improve check for page numbers #4113

bernhard-kleine opened this issue Jun 7, 2018 · 5 comments · Fixed by #4498
Labels
cleanup-ops good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement

Comments

@bernhard-kleine
Copy link

bernhard-kleine commented Jun 7, 2018

JabRef version 4.1 and all that followed

Since a couple of journals in the biomedical community have started to add letters to their page numbers, like American J Physiol, Current Biol and many others, it is no longer valid to label these page "numbers" as errorneous. That check should be modified.

@tobiasdiez
Copy link
Member

The purpose of the check is to find erroneous prefixes like pp. and this still makes sense even for alpha-numeric pages. The biblatex documentation (in the description of the command rangelen) contains a list of valid examples of the pages field. We should support all those formats and recognize them as valid input.

@tobiasdiez tobiasdiez added type: enhancement cleanup-ops good first issue An issue intended for project-newcomers. Varies in difficulty. labels Jun 7, 2018
@bernhard-kleine
Copy link
Author

bernhard-kleine commented Jun 7, 2018

I donot see in the biblatex description a format like (R for review) R40-R120 as in e.g. Current Biology. Or e2347-e2358 as in the Amer J Physiol; here e stands for endocrinology ..... Any section of the AJP journal has its own letter preceding page numbers. These are all regarded by Jabref as errorneous. The reality here is more advanced then the rules or the examples of biblatex.

@tobiasdiez tobiasdiez changed the title The check whether page numbers are mere numbers is superfluous Improve check for page numbers Jun 13, 2018
@tobiasdiez
Copy link
Member

As wished in http://discourse.jabref.org/t/pages-field-allow-use-of-en-dash/1199, the parser should also accept ranges separated by --.

@1160200515
Copy link

1160200515 commented Jul 5, 2018

Can you leave a screenshot or a more detailed explanation? My team and I want to improve this issue.But I didn't reproduce this problem.

@bernhard-kleine
Copy link
Author

bernhard-kleine commented Jul 16, 2018

If you take the DOI:10.1016/j.cub.2008.07.040 than you can see that the page range is: R795--R804. This raises the error "should have a valid page range".

tobiasdiez added a commit that referenced this issue Nov 19, 2018
Superseeds the PR #4188 and fixes #4113. Now page ranges like `R2-R5` are considered to be correct.
Siedlerchr pushed a commit that referenced this issue Nov 20, 2018
Superseeds the PR #4188 and fixes #4113. Now page ranges like `R2-R5` are considered to be correct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup-ops good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants