Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entry editor: simultaneous moving and renaming of document file? #4166

Closed
ilippert opened this issue Jul 4, 2018 · 9 comments
Closed

Entry editor: simultaneous moving and renaming of document file? #4166

ilippert opened this issue Jul 4, 2018 · 9 comments
Labels
entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@ilippert
Copy link
Contributor

ilippert commented Jul 4, 2018 •
edited
Loading

I believe in some distant past it was possible to use the context menu in the entry editor's file field to simultaneously move a file to the default file folder and rename it. This option has been disappearing a while ago and I wonder whether it is possible to add it again? It was so wonderful
@tobiasdiez tobiasdiez added ui entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. labels Jul 4, 2018
@Yueqing-Sun
Copy link

Hello, I am not sure if I understand this issue. Do you want to add a "Save As" function?

@ilippert
Copy link
Contributor Author

ilippert commented Jul 9, 2018

jabref allows for automatic renaming, e.g. using the bibtex citekey as a the filename.
in the current version, I can first use drag& drop to include a local link to the entry's file. then I can right-click and move it to the preferred document folder. and then I can right click (onto the file) again to rename the file (automatically, in my case the bibtex cite key).

I would hope the context menu/right click changes the "move" interaction, maybe with a simple checkbox "do you want the file to be renamed automatically?", and then simultaneously moves and renames the file automatically.

@tobiasdiez
Copy link
Member

I would simply add a "Move and rename" action in the right-click menu. Should be easiest solution.

upupming added a commit to upupming/jabref that referenced this issue Jul 17, 2018
@upupming
Fixed: JabRef#4166 add move & rename file
f1df0bc
@upupming upupming mentioned this issue Jul 17, 2018
Merged
6 tasks
tobiasdiez pushed a commit that referenced this issue Jul 17, 2018
@upupming @tobiasdiez
Fixed: #4166 add move & rename file (#4217)
31e6797 
* Fixed: #4166 add move & rename file

* Updated: CHANGELOG.md
@tobiasdiez
Copy link
Member

Thanks to @upupming, this is now implemented in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

Siedlerchr added a commit that referenced this issue Jul 23, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixtest
e01e445 
* upstream/master:
  single line text fields (#4138)
  Make it easier to rename and move files (#4200)
  Fix that swing dialogs are hidden behind main window (#4205)
  Fixed: #4166 add move & rename file (#4217)
@ilippert
Copy link
Contributor Author

I tested this for some minutes and it seems to work well. Thanks @upupming!

@upupming
Copy link
Contributor

@ilippert 😄 Glad to hear that~

Siedlerchr added a commit that referenced this issue Jul 24, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixattachfile
cfa2365 
* upstream/master:
  Update dependencies (#4231)
  Update to latest release of richtextfx (#4213)
  Fix fetcher tests (#4216)
  single line text fields (#4138)
  Make it easier to rename and move files (#4200)
  Fix that swing dialogs are hidden behind main window (#4205)
  Fixed: #4166 add move & rename file (#4217)

# Conflicts:
#	CHANGELOG.md
Siedlerchr added a commit that referenced this issue Jul 26, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixdragandrop
1d4db3d 
* upstream/master: (47 commits)
  Make attached files relative to the file directory (#4212)
  execute set visible in swing thread to avoid blocking
  Fix isbn chimbori test (#4234)
  Rewrite web search pane in JavaFX (#4203)
  Update dependencies (#4231)
  Update to latest release of richtextfx (#4213)
  Fix fetcher tests (#4216)
  single line text fields (#4138)
  Make it easier to rename and move files (#4200)
  Fix that swing dialogs are hidden behind main window (#4205)
  Fixed: #4166 add move & rename file (#4217)
  update gradle plugins and gradlen to 4.9
  Update dependencies
  Remove unnecessary look and feel migration (#4204)
  Revert threading fix since this sometimes lead to freezes...
  Update year
  Fix a few more threading exceptions
  Refactor
  Convert CiteSeerX fetcher to new infrastructure (#4185)
  Make global font size customizable (#4178)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/BasePanel.java
#	src/main/java/org/jabref/gui/JabRefFrame.java
#	src/main/java/org/jabref/gui/mergeentries/MergeEntries.java
#	src/main/resources/l10n/JabRef_en.properties
@ilippert ilippert mentioned this issue Sep 21, 2018
Closed
@tsmithe
Copy link

tsmithe commented Sep 28, 2019

Is it possible to do this in a batch? For instance, to rename the linked files for multiple entries at once.

@Siedlerchr
Copy link
Member

Sure,check out quality -> cleanup
There you can execute batch operations for all selected entries

@tsmithe
Copy link

tsmithe commented Sep 28, 2019

Thanks @Siedlerchr ! Until just a moment ago, I was stuck on Debian's ancient version 3.8 of JabRef (which didn't seem to have that option). But I finally managed to get 4.3.1 working, and it's just as you say. Thanks for the pointer :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Siedlerchr @tsmithe @tobiasdiez @ilippert @upupming @Yueqing-Sun