Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New entry from Id" supporting just adding with an id (and not the Id type) #550

Closed
koppor opened this issue Dec 21, 2015 · 21 comments
Closed
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui

Comments

@koppor
Copy link
Member

koppor commented Dec 21, 2015

As user, I want to generate an entry based on an Id. JabRef should know the id type by itself. Thus, the drop down "ID type" should be optional. Just reading the id and checking whether it is a valid doi, valid isbn, ... If yes, fetch the entry.

Additon: If an Id is pasted into the table, the entry should be created by the Id.

Old request

In the web search, we have two types of fetchers: The first types are crawlers (like IEEE or Springer) which return multiple entires. The second type are fetchers (like DOIToBibTeX, ISBNToBibTex, or Fetch ArXiv.org) which return a single entry.

Proposal move all single-entry-fetchers to "BibTeX -> New entry". One possibility is to offer a dropdown where the fetcher can be chosen. Next to the dropdown, the id of the entry can be input. Next to it, the button "Fetch" triggers the action.

Current UI

grafik

@simonharrer
Copy link
Contributor

Or something similar to "New entry ..." which has a sub-menu with all possibilities. This would help the user find this functionality more easily. Otherwise, it can be so well hidden that no one uses it.

@koppor
Copy link
Member Author

koppor commented Dec 21, 2015

I meant adding at the end of the "Select entry type" dialog. Marked below. I think, there, the users really find the possibility.

grabbed_20151221-103329

@simonharrer
Copy link
Contributor

Hm, I would not integrate this there but rather create a new action in the menu.

@koppor
Copy link
Member Author

koppor commented Dec 21, 2015

Is "there" above the "Cancel" button like

<Fetcher dropdown>  <input field for id>  [Fetch Button]

Example

DOI   10.1007/978-3-642-45005-1_64    Fetch

Then it's the same as I have in mind.

@stefan-kolb
Copy link
Member

@JabRef/developers This was done, right? Can be closed then...

@tobiasdiez
Copy link
Member

Kind of....it is in the "New entry..." dialog but in #1925 (comment) we said, that we also want to add a new "New entry from ID" dialog. I mark it as after-javafx.

@Siedlerchr
Copy link
Member

Thank you for reporting this issue. We think, that is already fixed in our development version and consequently the change will be included in the next release.

We would like to ask you to use a development build from https://builds.jabref.org/master and report back if it works for you.

@tobiasdiez
Copy link
Member

There is still no "New entry from ID" dialog. In the best case, this would be implemented as a new button in the toolbar that opens a small flyout pane.

@tobiasdiez tobiasdiez changed the title Web search should search for multiple entries only "New entry from ID" dialog Jun 13, 2018
@Siedlerchr
Copy link
Member

But in the new entry dialog is an option to enter doi etc

@koppor
Copy link
Member Author

koppor commented Jun 14, 2018

@Siedlerchr Please see the comment #1925 (comment) mentioned by @tobiasdiez:

I'm also in favor of a new menu-item + dialog. This also provides you more room to include a bit more details. My proposal:
Image
Has the advantage that the user need not select the kind of ID he has (most of them are quite distinct and JabRef should be able to tell them apart) and he gets a preview of the entry (which tells him that we put the correct ID in)

@stefan-kolb
Copy link
Member

stefan-kolb commented Jun 14, 2018 via email

@tobiasdiez tobiasdiez reopened this Nov 16, 2018
@stefan-kolb stefan-kolb added jabcon and removed jabcon labels Aug 23, 2019
@koppor koppor changed the title "New entry from ID" dialog "New entry from Id" supporting just adding with an id (and not the Id type) Nov 19, 2019
@koppor koppor added good first issue An issue intended for project-newcomers. Varies in difficulty. and removed status: help wanted labels Nov 19, 2019
@CarodePourtales
Copy link

Hello, I understand what you want, should I create a new NewEntryAction method for this new button or should I use the one already created used for the classic New Entry but if a type ? Thanks

@tobiasdiez
Copy link
Member

The functionality and the code should be moved to a new class. In addition, I would also add a new menu item.

@CarodePourtales
Copy link

Thanks a lot, that would you like as a "lookup" because so far I am using entry.toString().

Capture d’écran 2019-12-02 à 19 43 03
Capture d’écran 2019-12-02 à 19 43 26

@koppor
Copy link
Member Author

koppor commented Dec 2, 2019

Thank you for providing screenshots!

The identifier should be guessed. Meaning: The ISBN, the DOI, ... classes should be asked whether they can parse the identifier. If yes, the identifier type is found. That should happen directly after pasting. The belonging (fetched!) entry can be displayed inline in the same dialog.

There should be no separate dialog showing the fetched result. The fetched result should be directly inserted into the database and the entry editor should show that entry.

@tobiasdiez
Copy link
Member

I agree with @koppor. Please have a look at #550 (comment) for how it should like (approximately).
For the display of the entry, it is probably worthwhile to reuse (reuse, not copy!) the following code:

private Node getEntryNode(BibEntry entry) {
Node entryType = getIcon(entry.getType()).getGraphicNode();
entryType.getStyleClass().add("type");
Label authors = new Label(entry.getFieldOrAliasLatexFree(StandardField.AUTHOR).orElse(""));
authors.getStyleClass().add("authors");
Label title = new Label(entry.getFieldOrAliasLatexFree(StandardField.TITLE).orElse(""));
title.getStyleClass().add("title");
Label year = new Label(entry.getFieldOrAliasLatexFree(StandardField.YEAR).orElse(""));
year.getStyleClass().add("year");
Label journal = new Label(entry.getFieldOrAliasLatexFree(StandardField.JOURNAL).orElse(""));
journal.getStyleClass().add("journal");
VBox entryContainer = new VBox(
new HBox(10, entryType, title),
new HBox(5, year, journal),
authors
);
entry.getFieldOrAliasLatexFree(StandardField.ABSTRACT).ifPresent(summaryText -> {
TextFlowLimited summary = new TextFlowLimited(new Text(summaryText));
summary.getStyleClass().add("summary");
entryContainer.getChildren().add(summary);
});
entryContainer.getStyleClass().add("bibEntry");
return entryContainer;
}

@GuillaumeD-IMTA
Copy link

@CarodePourtales how is it going? Do you need help ?

@tobiasdiez
Copy link
Member

There is still no "New entry from ID" dialog. In the best case, this would be implemented as a new button in the toolbar that opens a small flyout pane.

@koppor
Copy link
Member Author

koppor commented Jun 27, 2021

The functionality described by Tobias is #4183.

@koppor
Copy link
Member Author

koppor commented Jun 27, 2021

Current state of the dialog:

grafik

@koppor
Copy link
Member Author

koppor commented Nov 29, 2021

Fixed by #8129

@koppor koppor closed this as completed Nov 29, 2021
@JabRef JabRef deleted a comment from github-actions bot Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An issue intended for project-newcomers. Varies in difficulty. type: enhancement ui
Projects
None yet
Development

No branches or pull requests

8 participants