Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JabRef logo as tiff for Mac OS installer (retina support) #5759

Closed
Siedlerchr opened this issue Dec 17, 2019 · 16 comments · Fixed by #6306
Closed

Add JabRef logo as tiff for Mac OS installer (retina support) #5759

Siedlerchr opened this issue Dec 17, 2019 · 16 comments · Fixed by #6306
Labels
build-system good first issue An issue intended for project-newcomers. Varies in difficulty. os: macOS type: enhancement

Comments

@Siedlerchr
Copy link
Member

The jpackage tool has now the option to provide a tiff with high resolution for Mac OS retina
displays. JabRef should also provide a high resolution image.

Refs: https://bugs.openjdk.java.net/browse/JDK-8234284

Some tutorials. It seems to be someone with a mac is required.

https://computers.tutsplus.com/tutorials/how-to-create-a-retina-ready-dmg-based-app-installer--cms-21653

https://developer.apple.com/library/archive/documentation/GraphicsAnimation/Conceptual/HighResolutionOSX/Optimizing/Optimizing.html

@Siedlerchr Siedlerchr added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Mar 3, 2020
@Gena928
Copy link
Contributor

Gena928 commented Apr 12, 2020

@Siedlerchr
if I understand correctly, you need a Tiff file with 2 images: hi res & low res. As stated in this video https://computers.tutsplus.com/tutorials/how-to-create-a-retina-ready-dmg-based-app-installer--cms-21653 - scroll to 4:27

Correct?

@Siedlerchr
Copy link
Member Author

@Gena928 Exactly. You can find the original tiff here:
https://github.com/openjdk/jdk/blob/master/src/jdk.incubator.jpackage/macosx/classes/jdk/incubator/jpackage/internal/resources/background_dmg.tiff

I have attached our JabRef Logo: Maybe you can integrate or design a new picture with JabRef's logo in it. That would be cool
jabref_logo_without-bg.zip

@Gena928
Copy link
Contributor

Gena928 commented Apr 15, 2020

@Siedlerchr
I have some design problems. ))) Give me a few days, I'll try to create something normal.
Google drive folder with sample image

@Siedlerchr
Copy link
Member Author

Yeah looks already good! Thanks for stepping in. Take your time. It's not a critical issue 😎

@Gena928
Copy link
Contributor

Gena928 commented Apr 16, 2020

@Siedlerchr
please see sample images in "All screenshots" folder: Google drive folder with samples

Any comments a highly appreciated. Design is very sensitive area, so if you think you need more options from other people, let's wait for more contributors for this issue.

@Siedlerchr
Copy link
Member Author

Thank you very much for your work proposals! I pinged the other devs for a quick look.
@JabRef/developers

@tobiasdiez
Copy link
Member

Thanks @Gena928, they screenshots look really good. I like the "Simple with comment" the most. Some comments:

  • Having the JabRef icon twice feels a bit too much. I would remove the big one at the top.
  • Is it possible to make the icons at the bottom a bit larger?
  • The arrow is a bit "fancy". Can you replace them with a somewhat simpler one?
  • The font color and family should match the one we use in our flyers. I.e. "JABREF" should be blue, and the "To install, ..." text black. @stefan-kolb which font did you used?
    flyer

I liked the following ones:
firefox
Without the "firefox" below the icon and with an installation note as in
moro

@stefan-kolb
Copy link
Member

stefan-kolb commented Apr 16, 2020

@stefan-kolb which font did you use?

https://www.dafont.com/de/bebas-neue.font

@Gena928
Copy link
Contributor

Gena928 commented Apr 16, 2020

@stefan-kolb
Sorry, simple "Bebas Neue" or maybe "Rounded", "by FontFabric"?
https://fonts.adobe.com/foundries/dharma-type

@Gena928
Copy link
Contributor

Gena928 commented Apr 16, 2020

Added 2 new samples:

  • Simple Bebas Neue font (w bg).png
  • Simple Bebas Neue font.png

@Siedlerchr
Copy link
Member Author

@Gena928 Toe me the Bebas variant without a background is the best. Matches the flyer

@tobiasdiez
Copy link
Member

Wow, that looks nice. I agree with @Siedlerchr that the Bebas layout with the white background looks the best. One small remark: I think it should be "to the Applications folder" in the description.

@Gena928
Copy link
Contributor

Gena928 commented Apr 17, 2020

OK, the image is updated. Source files are located in "Simple Bebas Neue font" folder.

When I created dmg install file, I used the following settings:

  • JabRef & Applications icons are of 84 size (dmg file properties);
  • font size of JabRef icon & Applications icon - 12 px;

Any more comments are welcome.

@tobiasdiez
Copy link
Member

Perfect! I think you can go ahead and create the PR.

@Gena928
Copy link
Contributor

Gena928 commented Apr 17, 2020

PR created.
Is it OK if I attach images in PR comment as ZIP file?

tobiasdiez pushed a commit that referenced this issue Apr 18, 2020
…#6306)

* Updated CHANGELOG.md

* Added background_dmg.tiff file
@tobiasdiez
Copy link
Member

Thanks to @Gena928 this is now implemented in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks! Please remember to make a backup of your library before trying-out this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-system good first issue An issue intended for project-newcomers. Varies in difficulty. os: macOS type: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants