Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed group drag-n-drop not working after inserting an article into a group #6008

Merged
merged 2 commits into from
Feb 24, 2020

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Feb 24, 2020

fixes #5510
Credit goes all to @mgroth0, who had Problems with git uploading this fix. Played around a little bit, I don't see any new issue arise from this fix.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for bigger UI changes)
  • Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 24, 2020
@Siedlerchr Siedlerchr merged commit 4eefcc6 into JabRef:master Feb 24, 2020
Siedlerchr added a commit that referenced this pull request Feb 26, 2020
* upstream/master:
  Fixed group drag-n-drop not working after inserting an article into a group (#6008)
  New Crowdin translations (#5998)
  Bump richtextfx from 0.10.3 to 0.10.4 (#6007)
  Bump unirest-java from 3.5.00 to 3.6.00 (#6006)
  Bump com.github.ben-manes.versions from 0.27.0 to 0.28.0 (#6004)
  Bump classgraph from 4.8.64 to 4.8.65 (#6003)
  Bump mockito-core from 3.2.4 to 3.3.0 (#6005)
  Update module description (#5999)
Siedlerchr added a commit that referenced this pull request Mar 6, 2020
* upstream/master:
  Fix teamscale link - and sort list alphabetically
  Update code-quality.md
  Update link to codacy/JabRef
  Integrate gradle validation in normal test workflow (#6001)
  Fixed group drag-n-drop not working after inserting an article into a group (#6008)
  New Crowdin translations (#5998)
  Bump richtextfx from 0.10.3 to 0.10.4 (#6007)
  Bump unirest-java from 3.5.00 to 3.6.00 (#6006)
  Bump com.github.ben-manes.versions from 0.27.0 to 0.28.0 (#6004)
  Bump classgraph from 4.8.64 to 4.8.65 (#6003)
  Bump mockito-core from 3.2.4 to 3.3.0 (#6005)
@calixtus calixtus deleted the fix_5510 branch March 10, 2020 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reordering Groups does not work after previous drag & drop
2 participants