Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BibteXML syntax #898

Closed
zesaro opened this issue Mar 1, 2016 · 5 comments
Closed

BibteXML syntax #898

zesaro opened this issue Mar 1, 2016 · 5 comments

Comments

@zesaro
Copy link
Contributor

zesaro commented Mar 1, 2016

The BibteXMLImporter only accepts xml files where tags have a syntax like <bibtex:author>. Otherwise JabRef does not read the data or even the file. Shouldn't it be possible to read files with normal syntax?
I created a few tests for this Importer. Two tests of them are ignored, because otherwise circleci would return an error.

Refs #511

@koppor
Copy link
Member

koppor commented Mar 1, 2016

The BibTeXML parser is implemented in a wrong way. BibTeXML is a DTD document. XML is namespace aware. Therefore, the document should be parsed namespace aware.

Proposal: Rewrite the whole BibTeXML parser using javax.xml.parsers.DocumentBuilderFactory.

@koppor
Copy link
Member

koppor commented Mar 11, 2016

Update: Schemas are available at https://github.com/Zearin/BibTeXML/tree/master/bibtexml/schema . I would propose to build on the XML Schema

@tschechlovdev
Copy link
Contributor

I would like to take care of this issue. But in my opinion a JAXB parser would be easier than just using a DOM parser. Would this be also ok?

@Siedlerchr
Copy link
Member

JAXB sounds like a good idea. Mabye you can reuse some of your code.

@tschechlovdev
Copy link
Contributor

#1666 is merged, so I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants