Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update download comment at PR if PR closed #10057

Merged
merged 6 commits into from
Jul 3, 2023
Merged

Update download comment at PR if PR closed #10057

merged 6 commits into from
Jul 3, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Jul 3, 2023

We also have an action adding a link to the build at the PR (

- name: Comment PR
). We have an action removing the branch on builds.jabref.org (https://github.com/JabRef/jabref/blob/main/.github/workflows/cleanup_pr.yml). Then, the link is 404. Thus, the comment should be deleted. This PR tries that.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor closed this Jul 3, 2023
@koppor
Copy link
Member Author

koppor commented Jul 3, 2023

Switched to message replacing. Reasons:

  1. Deletion should delete new comment, not the "updated" one thollander/actions-comment-pull-request#247
  2. A user might be confused: "I swear, I saw a comment of the GitHub bot. Where is it now?"

@koppor koppor closed this Jul 3, 2023
@koppor koppor reopened this Jul 3, 2023
@koppor koppor closed this Jul 3, 2023
@koppor koppor reopened this Jul 3, 2023
@koppor koppor closed this Jul 3, 2023
@koppor koppor reopened this Jul 3, 2023
@koppor koppor changed the title Try to remove comment at PR Update download comment at PR if PR closed Jul 3, 2023
@koppor koppor marked this pull request as ready for review July 3, 2023 19:30
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

A build of this PR is not available. Head to https://builds.jabref.org/main/ for the latest build.

@calixtus calixtus merged commit 357f486 into main Jul 3, 2023
@calixtus calixtus deleted the remove-comment branch July 3, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants