Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to use ISBN & ArXiv ID in websearch #10063

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

aqurilla
Copy link
Contributor

@aqurilla aqurilla commented Jul 3, 2023

This fixes #7575 by adding a pre-processing step to the web search, using org.jabref.logic.importer.CompositeIdFetcher.
This is a followup to PR #9969, and extends the logic to cover ISBN and ArXiv ID cases as well.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@aqurilla aqurilla marked this pull request as ready for review July 3, 2023 15:28
calixtus
calixtus previously approved these changes Jul 3, 2023
@calixtus calixtus merged commit a340e4c into JabRef:main Jul 3, 2023
@calixtus
Copy link
Member

calixtus commented Jul 3, 2023

😍

@koppor
Copy link
Member

koppor commented Jul 3, 2023

Thank you for the ongoing good contributions @aqurilla!

The "design" added in this PR allows for adding RFC and other IDs easily. Let's see when users will ask for it.

@aqurilla
Copy link
Contributor Author

aqurilla commented Jul 4, 2023

Glad to hear that, thankyou!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entering an Id at the Web Search should search for the id - and not throw an Exception
3 participants