Fixes NPE in Export to External DB #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -541,7 +543,8 @@ public void run() { | |||
| frame.output(Localization.lang("Attempting SQL export...")); | |||
| final DBExporterAndImporterFactory factory = new DBExporterAndImporterFactory(); | |||
| final DBExporter exporter = factory.getExporter(dbs.getServerType()); | |||
| exporter.exportDatabaseToDBMS(database, bibDatabaseContext.getMetaData(), null, dbs, frame); | |||
There was a problem hiding this comment.
Should really only the selected entries be exported or all (getDatabase().getEntries)? Previously null indicated the latter.
There was a problem hiding this comment.
Okay, then I think I take better all entries to be consistent
Export all entries by default Add DB Type to Export Succesful message Reformatting JabRef#1055
|
Export now all entries by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NPE in Export to External DB
Add DB Type to Export Succesful message
Reformatting
#1055
No Changelog because I think it was new introduced by the redesign of the Entry sorting (passing null)