Apply RemoveTestPrefix #10823
Apply RemoveTestPrefix #10823
Conversation
koppor
added
the
type: code-quality
koppor
added
the
status: ready-for-review
|
Only FetcherTests fail, because of CiteSeer and Grobid (and others) |
| String formattedStr = formatter.format(specialChar); | ||
| assertEquals(expectedResult, formattedStr); | ||
| } | ||
|
|
||
| @Test | ||
| void testRTFCharacters() { | ||
| void rTFCharacters() { |
There was a problem hiding this comment.
|
I don't like this refactoring, Even though it's not necessary, I find it easier to have the methods with test prefixed, helps it to find them |
|
I have no strong opinion here, but it should be consistent everywhere. For now we have methods with and some without the prefix. About the argument: I think the ide should help here. In intellij test classes have a green bg. But I don't know if this is what you mean? What's more of interest to me in this matter is: what recommendation does junit make and how do the error messages look if junit produces some. |
|
+1 for consistency. Therefore, I applied it. It is also based on the experience by our friends at Moderne. Thus, I trust them --> https://docs.openrewrite.org/recipes/java/testing/cleanup/removetestprefix |
|
There is something wrong with the lobid fetcher: Failed to map supported failure 'org.opentest4j.AssertionFailedError: expected: <Optional[Paper Title]> but was: <Optional.empty>' with mapper 'org.gradle.api.internal.tasks.testing.failure.mappers.OpenTestAssertionFailedMapper@151d4a62': Cannot invoke "Object.getClass()" because "expectedValue" is null |
|
This PR did not touch the LOBID fetcher:
|
|
Run of yesterday: No LOBID errors: https://github.com/JabRef/jabref/actions/runs/7681234187/job/20949458284?pr=10823 |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
* upstream/main: Fix NPE when tab is close during load (#10841) Bump peter-evans/create-or-update-comment from 3 to 4 (#10838) Bump styfle/cancel-workflow-action from 0.12.0 to 0.12.1 (#10835) Bump lycheeverse/lychee-action from 1.9.1 to 1.9.3 (#10837) Bump gradle/gradle-build-action from 2 to 3 (#10836) Bump com.puppycrawl.tools:checkstyle from 10.12.7 to 10.13.0 (#10830) Bump org.mockito:mockito-core from 5.9.0 to 5.10.0 (#10834) Bump org.openrewrite.rewrite from 6.7.0 to 6.8.1 (#10833) Bump org.openrewrite.recipe:rewrite-recipe-bom from 2.6.2 to 2.6.3 (#10832) Apply RemoveTestPrefix (#10823) Update to jdk 21.0.2 (#10827) Fix escaping of slashes for TexShop (#10826)
Follow-up to #10797 and #10799.
This applies Remove test prefix from JUnit 5 tests and fixes the issues caused by openrewrite/rewrite-testing-frameworks#462 manually.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)