Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for (biblatex) langid field in entry editor #10868 #11049

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

Skydrite
Copy link
Contributor

@Skydrite Skydrite commented Mar 19, 2024

Issue Link

This pull request resolves [#10868](https://github.com/JabRef/jabref/issues/10868) (Support for (biblatex) langid field in entry editor)

Issue description

The field langid is missing among the standard fields, which is used for hyphenation and whether sentence casing is applied.

Modifications and Results

At org.jabref.model.entry.field.StandardField#StandardField, the enum StandardField was missing the constant langid which was added. It is now possible to add the langid field to an entry type through the preferences menu.

Tests Added

No new tests were added, as the only change was adding a constant to an enum. Also, no tests relating to other standard fields were found in test.org.jabref.model.entry.field.StandardField#StandardField.

Mandatory

  • Change in [CHANGELOG.md](http://changelog.md/) described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)

JabRef-screenshot

Discussion

  1. Should we still add new tests? If so, can you give pointers as to how we can test this?
  2. Should we open new issues for the missing implementation of importers/exporters supporting the langid field?

@enesbkoca
Copy link

I'm working together with @Skydrite, and we will address the one failing unit test which is caused by the comparison of the xml file created prior. We are going to fix this by adding the corresponding table-cell of langid and value insideOldOpenOfficeCalcExportFormatContentSingleEntry.xml located insrc/test/resources/org/jabref/logic/exporter/OldOpenOfficeCalcExportFormatContentSingleEntry.xml.

@koppor koppor marked this pull request as draft March 19, 2024 20:34
…ard field "langid". Also change enum constant to match other constants in StandardField.java.
@Siedlerchr Siedlerchr marked this pull request as ready for review March 19, 2024 21:04
@Siedlerchr Siedlerchr added this pull request to the merge queue Mar 19, 2024
@Siedlerchr
Copy link
Member

Thanks for the quick follow up and for contribution!

Merged via the queue into JabRef:main with commit 0aaebad Mar 19, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants