Fix black text in Dark mode inside "Citation information" #11578
Conversation
|
Looks great for fixing the issue! However, what could be done more is to fix black text on Dark theme more general. You see, there are lot's of strange places in JabRef, where text is rendered black in Dark theme. And "Citation information" is only one of those places. That's why I added a comment on one of the issues: #11512 (comment). If you can, try to investigate which classes are affected, where are these classes stored, on what conditions black text doesn't appear white. If you struggle, that's okay! I should've made a general issue for that. For "Citation information" you did right |
| } | ||
|
|
||
| #citationsPane { | ||
| -fx-padding: 0; | ||
| -fx-background-color: -fx-control-inner-background; | ||
| } | ||
|
|
||
| #citationsPane * { |
There was a problem hiding this comment.
I'm a little worried about: what if this wildcard would affect style of other nodes? I guess, you tested everything and it works?
Also, I'm wondering, it doesn't work without this wildcard?
➕ A little space between class name and bracket will look good
| @@ -158,7 +157,6 @@ | |||
| .scite-message-box { | |||
| -fx-padding: 30 0 0 30; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Do not remove empty lines as separators
|
Will this affect "light mode"? |
| } | ||
|
|
||
| #citationsPane { | ||
| -fx-padding: 0; | ||
| -fx-background-color: -fx-control-inner-background; | ||
| } | ||
|
|
||
| #citationsPane * { |
I checked and fixed. Works on both. |
koppor
added
the
status: ready-for-review
Closes #11512
UI screenshots
Changes made
scite-message-contentfor text which are shown in black#citationsPaneuniversal selecter to class selector to select.scite-message-content.