Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1163 by removing the strange functionality which enabled sorting… #1168

Merged
merged 1 commit into from
Apr 11, 2016

Conversation

simonharrer
Copy link
Contributor

We have some very strange logic in JabRef which allows to handle years using only the two last numbers, so we can detect that 68 means 1968. This causes a lot of issues. I do not think that JabRef should still support such strange logic, and just use the value which is in the year field.

Hence, I removed it.

This also solves the issue of having that YearUtil in the model package which duplicated a method in the StringUtil class.

Refs #1163

@tobiasdiez
Copy link
Member

LGTM 👍

1 similar comment
@stefan-kolb
Copy link
Member

LGTM 👍

@simonharrer simonharrer merged commit a1696ae into master Apr 11, 2016
@koppor
Copy link
Member

koppor commented Apr 12, 2016

Should we readd YearUtil as a cleanup to convert two digit years to four digit years?

@Siedlerchr
Copy link
Member

If we add it, we should make use of the java 8 functionality instead of the own ugly parsing:
http://stackoverflow.com/questions/32505490/how-to-change-the-base-date-for-parsing-two-letter-years-with-java-8-datetimefor

and this one:
http://stackoverflow.com/questions/29490893/parsing-string-to-local-date-doesnt-use-desired-century

@stefan-kolb stefan-kolb deleted the fix-1163 branch April 13, 2016 18:03
@stefan-kolb stefan-kolb restored the fix-1163 branch April 13, 2016 18:03
@stefan-kolb stefan-kolb deleted the fix-1163 branch April 13, 2016 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants