Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctrl+f selects current query while the searchbar is focusd #2457

Merged
merged 1 commit into from
Jan 12, 2017
Merged

ctrl+f selects current query while the searchbar is focusd #2457

merged 1 commit into from
Jan 12, 2017

Conversation

chriba
Copy link
Contributor

@chriba chriba commented Jan 12, 2017

Implemented a feature request from the forum (http://discourse.jabref.org/t/ctrl-f-behaviour/408).

When pressing Ctrl + F and the searchbar is already focused the current query will be selected.
This is the same behavior as many other programs have.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Screenshots added (for bigger UI changes)
  • Manually tested changed features in running JabRef
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)
  • If you changed the localization: Did you run gradle localizationUpdate?

@tobiasdiez
Copy link
Member

Thanks for your PR!

@tobiasdiez tobiasdiez merged commit c6620f4 into JabRef:master Jan 12, 2017
@chriba chriba deleted the ctrlFInsideSearchbar branch January 12, 2017 14:50
Siedlerchr added a commit that referenced this pull request Jan 13, 2017
* upstream/master: (67 commits)
  Medline fix test (#2463)
  Fix conversion of tilde n (#2459)
  ctrl+f selects current query while the searchbar is focusd (#2457)
  incorrect log name of JabRefExecutorService (#2452)
  unregister DateChangeListener in manual update method (#2450)
  Escaping of escape symbols in the MetaData (#2445)
  Fix typo
  Update gradle from 3.2.1 to 3.3
  Use instanceof
  Remove unused import
  Avoid ClassCastException in AutoCompleteListener
  Fix typo in CHANGELOG.md
  Add support for pages in the format 2:1-2:33 (#2440)
  L10N-ru update (#2441)
  Change https to http
  Update DBLP API endpoint
  Revert "Chistmas edition colors"
  Show development information
  Release v3.8.1
  Result of generate-authors.sh
  ...

# Conflicts:
#	CHANGELOG.md
#	src/main/java/net/sf/jabref/gui/date/DatePickerButton.java
@jdpipe
Copy link

jdpipe commented Feb 4, 2017

working nicely with JabRef 3.8.2 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants