…ns in the linked file. Confusion because the gridpane is initially disabled even if there are annotations. After clicking on the file in the Combobox it works fine.

- litle ui changes

* Migrate paramterized RIS tests to JUnit5

* Extract generic importer testing code to new class

* Switch to JUnit5 assertions in BibEntryAssert

* Remove unused imports

* Use static import for Assertion when possible

* Extract file collection from importer test classes

* Refactor biblioscape importer tests

* Refactor BiblioscapeImporterTestTypes to JUnit5 syntax

* Refactor CopacImporterTestFiles

* Migrate medline importer tests to JUnit5

* Convert BibTeXML importer tests to JUnit5

* Move several non-parametric importer test classes to JUnit5

* Refactor Medline importer tests to JUni5

* Migrate parameterized MODS importer tests to JUnit5

* Migrate MrDLib importer tests to JUnit5

* Migrate MsBibImporter tests to JUnit5

* Migrate OvidImporter tests to JUnit5

* Migrate PdfContentImporter tests to JUnit5

* Migrate PdfXmpImporter tests to JUnit5

* Migrate RepecNepImporter tests to JUnit5

* Migrate RISImporter tests to JUnit5

* Migrate SilverPlatterImporter tests to JUnit5

* Fix imports in SilverPlatterImporterTest

* Fix BibTeXMLImporter tests

* Fix and clarify BibTeXMLImporterTestTypes

* Fix medline tests for malformed files

* Remove unused imports

* Fix broken test files that can be fixed and remove the ones with larger syntactic problem

* Fix MODSImporter tests

* Fix test file for MsBibImporter tests

* Convert Before to BeforeEach in OvidImporterTests

* Check starting line of a file for checking whether it is a PDF

* Migrate additional BibTeXML tests to JUnit5

* Refactor and restructure BibTexParser tests

* Refactor CopacImporter tests

* Refactor BibTeXMLImporter tests

* Refactor EndnoteImporter tests

* Refactor FreeCiteImporter tests

* Refactor InspecImporter tests

* Refactor IsiImporter tests

* Refactor MedlineImporter tests

* Refactor MrDLibImporter tests

* Refactor MsBibImporter tests

* Refactor OvidImporter tests

* Refactor PdfXmpImporter tests

* Refactor RepecNepImporter tests

* Refactor SilverPlatterImporter tests

* Fix a bunch of codacy issues

…lEverything

* Only remove file links from entries by default (#3679)

When a file link in a bibliography entry is deleted by the user,
a dialog is displayed. Previously, the default (first) dialog option
deleted the linked file from disk. This commit changes the default
behaviour to just removing the file link from the entry.

* Fix canceling bug in file link deletion dialog

When clicking "Cancel" button in the file link deletion dialog, the file
link was being deleted from the list. This commit fixes this behaviour
by changing the return value of the delete() method when the "Cancel"
button is chosen.

* Tag link removal button as default (#3679)

The "remove from entry" option in the file link removal dialog window
has been tagged with the ButtonData.YES type to ensure correct
positioning and behaviour on all platforms.

* Add test cases for linked file removal dialog

* Code style adjustments in dialog test cases

* Added non-empty link to file in one test for clarity
* Removed unnecessary newlines
* Changed test method names to adhere to chosen naming convention

…hapter

…lications detection process; add more tests

Fixed the issue "DOI: encoded URLs should be supported". New divider within the DOI % is supported.

* 'master' of github.com:JabRef/jabref:
  Allow spaces in DOIs
  Remove irrelevant log messages during XMP reading
  Adapt log4j configuration for cleaner junit tests #3511
  Eclipse Django style #3655
  Better code style for chained methods
  Update build.gradle
  Update build.gradle
  cleanup and refactoring in DuplicateCheck class
  code review fixes - consider pages of the same book separately in duplications detection process; add more tests
  differentiate inbooks with the same author and title, but different chapter
  Remove deprecated static BibtexParser.parse method
  Use stream in matcher (#3696)
  Add some BibtexNameFomatter comments
  Add exception for Jacoco
  Set jacoco toolVersion earlier
  set jacoco version globally

# Conflicts:
#	src/main/java/org/jabref/gui/DefaultInjector.java

# Conflicts:
#	CHANGELOG.md

Follow up on #3698 annotation tab improvements

DOI encoded with % supported

Duplicated functionality, if file already exists. Asks twice, if a file should be overriden.

mock import and convert to junit5

Group separator escaping

please check if I didn't forgot one Test annotation

remove unnecessary supplier
convert some more tests to junit5
fix imports

Mock externalFileTypes in importer test