Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to git subtree #5647

Merged
merged 7 commits into from
Nov 20, 2019
Merged

Switch to git subtree #5647

merged 7 commits into from
Nov 20, 2019

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 20, 2019

We have issues with git submodules. Since we "just" need to have the code in our repostiory, git submoulde seems to be the better choice.

This PR switches from sub modules to sub trees. Including an update twice a month. Maybe, I need to play around with push-rights to the master branch. Will do that later to keep things moving.

Sorry for 6408457. This should not be in here, but it's difficult to remove it with git rebase -i.

More background information:

@koppor koppor marked this pull request as ready for review November 20, 2019 06:00
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Nov 20, 2019
@Siedlerchr
Copy link
Member

I would suggest you create an ADR as well for this decision and please update the getting started guides on cloning and fetching
Otherwise subtrees seem to be a better solution.

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A follow-up would be to write a small python script that creates and updates an index file for the citation styles (and then also include this in the update workflow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants