Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove background command line window #5965

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Remove background command line window #5965

merged 1 commit into from
Feb 20, 2020

Conversation

tobiasdiez
Copy link
Member

Fixes #5474. Apparently, the upstream bug in the jdk concerning cmd line arguments was fixed in the meantime, which makes the win-console toggle obsolete.

Only problem I've encountered so far is that no logger output is written to the console. Combined with the Log4j issues we have at the moment, this means that for users it's not possible to report detailed stack traces etc. Workaround: use .\runtime\bin\JabRef to start JabRef instead of JabRef.exe (I would add this to the release notes under "known issues").

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for bigger UI changes)
  • Checked documentation: Is the information available and up to date? If not: Issue created at https://github.com/JabRef/user-documentation/issues.

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 19, 2020
@Siedlerchr
Copy link
Member

I would prefer the log4j issue be fixed and in the meantime I would let stay the console open for error messages

@koppor
Copy link
Member

koppor commented Feb 20, 2020

❤️

We already have the help in the UI

grafik

grafik

I would assume this is enough for users to send issues.

Even if this is not the case anymore, the background window will disturb many more users than those reporting issues.

@koppor koppor merged commit 505fc74 into master Feb 20, 2020
@koppor koppor deleted the removeCmd branch February 20, 2020 11:17
@koppor koppor mentioned this pull request Feb 20, 2020
Merged
5 tasks
Siedlerchr added a commit that referenced this pull request Mar 6, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master'
f22a640 
* upstream/master:
  Add option to parse new references from plain text using GROBID… (#5614)
  update jlink plugin and gradle to 6.2 (#5964)
  Remove background command line window (#5965)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove background command line window
3 participants
@tobiasdiez @Siedlerchr @koppor