Fixed some issues in exporter #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
force-pushed
the
exporterfixes
branch
from
0a0a272
to
eda35fd
Compare
|
|
||
| ### Removed | ||
|
|
||
| - Fixed #627: The pdf field is removed from the export formats, use the file field |
There was a problem hiding this comment.
I think the new format is now Fixed [#num](link to github)
There was a problem hiding this comment.
OK! Wasn't sure if that was something that was edited before a release only.
|
Just a few minor remarks, otherwise 👍 |
oscargus
added
bug
|
Edited the Changelog (and added the issue that reported the thing I fixed). The exception things I do not really know what to do about. Of course the exception handling can be improved further, but compared to the previous code, this is at least a bit improved. |
oscargus
force-pushed
the
exporterfixes
branch
from
8c9dd83
to
bbfb75e
Compare
|
Rebased again. Anything else that needs to be fixed? I know that the Exception handling is not brilliant, but nothing I introduced (it is probably slightly more brilliant now though...). |
simonharrer
added a commit
that referenced
this pull request
Jan 19, 2016
Fixed some issues in exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue in the MS Office 2007 exporter and some code cleanups.
Removed all(?) references to the pdf field and the non-existing ResolvePDF export formatter.
Removed duplicate lines in the ChangeLog for 3.2, fixes #627.