Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check external links once a month #6695

Merged
merged 2 commits into from
Jul 18, 2020
Merged

Check external links once a month #6695

merged 2 commits into from
Jul 18, 2020

Conversation

koppor
Copy link
Member

@koppor koppor commented Jul 17, 2020

Test external links in documentation

Context and Problem Statement

The JabRef repository contains Markdown (.md) files documenting the JabRef code.
The documentation contains links to external resources.
For high-quality documentation, external links should be working.

Currently we check at each PR (option 2 below), but that is annoying. See #6677.

Decision Drivers

  • Checking external links should not cause issues in the normal workflow

Considered Options

  • Check external links once a month
  • Check external links in the "checkstyle" task
  • Do not check external links

Decision Outcome

Chosen option: "[option 1]", because [justification. e.g., only option, which meets k.o. criterion decision driver | which resolves force force | … | comes out best (see below)].

Positive Consequences

  • Automatic notification of broken external links

Negative Consequences

Pros and Cons of the Options

Check external links once a month

  • Good, because does not interfer with the normal development workflow
  • Bad, because an additional workflow is required

Check external links in the "checkstyle" task

  • Good, because no seperate workflow is required
  • Bad, because checks fail independent of the PR (because external web sites can go down and go up independent of a PR)

Do not check external links

  • Good, because no testing at all is required
  • Bad, because external links break without any notice
  • Bad, because external links have to be checked manually
  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor koppor mentioned this pull request Jul 17, 2020
@tobiasdiez
Copy link
Member

Thanks!

@koppor koppor merged commit ee2c985 into master Jul 18, 2020
@koppor koppor deleted the move-link-check branch July 18, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants