Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DoiDuplicationCheckerTest to increase coverage #7698

Merged
merged 2 commits into from
May 6, 2021
Merged

Added DoiDuplicationCheckerTest to increase coverage #7698

merged 2 commits into from
May 6, 2021

Conversation

ningxie1991
Copy link
Contributor

@ningxie1991 ningxie1991 commented May 3, 2021

This pull request contributes to issue #6207, which is to add more unit tests or improve existing ones. I used Pitest to compute the line and mutation coverage. Since DoiDuplicationChecker did not have its unit test (its method was being tested in other test classes), I added the test to increase both coverages.

Before:
image

After:
image

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general: Looks good to me.

Some code nitpick: variable naming

@ningxie1991 ningxie1991 requested a review from koppor May 4, 2021 08:30
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 4, 2021
@Siedlerchr Siedlerchr merged commit aa2d3b9 into JabRef:main May 6, 2021
@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants