Refactoring existing unit tests into parametrized tests #7700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syncing local fork i
Siedlerchr
requested changes
May 4, 2021
src/test/java/org/jabref/logic/layout/format/AuthorOrgSciTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/layout/format/EntryTypeFormatterTest.java
Show resolved
Hide resolved
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
koppor
removed
the
status: changes required
|
Thanks for your contribution, we took the liberty to finish it ourselves. |
Siedlerchr
added a commit
that referenced
this pull request
Jun 8, 2021
* upstream/main: Refactoring existing unit tests into parametrized tests (#7700) Replace <p> in localization by \n (#7279) Bump byte-buddy-parent from 1.11.0 to 1.11.1 (#7800) Bump org.javamodularity.moduleplugin from 1.8.6 to 1.8.7 (#7799) Bump mockito-core from 3.10.0 to 3.11.0 (#7801) Bump classgraph from 4.8.106 to 4.8.108 (#7802) Update .markdownlint.yml Ignore slant.co links GitBook: [main] 3 pages and 17 assets modified GitBook: [main] one page modified GitBook: [main] one page modified GitBook: [main] 6 pages and 42 assets modified # Conflicts: # build.gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contributes to issue #6207, which is to add more unit tests or improve existing ones.
Tests refactored:
DoiStripTest
DefaultTest (ParamLayoutFormatter)
ToUpperCaseTest
IfPluralTest
HTMLParagraphsTest
EntryTypeFormatterTest
AuthorOrgSciTest
AuthorNatBibTest
AuthorFirstLastCommasTest
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)