Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Aux dialog and logic #900

Merged
merged 8 commits into from
Mar 5, 2016
Merged

Rework Aux dialog and logic #900

merged 8 commits into from
Mar 5, 2016

Conversation

stefan-kolb
Copy link
Member

No description provided.

nestedAuxCounter = -1; // count only the nested reads
private void parseAuxFile(String filename) {
// nested aux files
List<String> fileList = Arrays.asList(filename);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

asList(T... a)
Returns a fixed-size list backed by the specified array.

So it won't work to add file names later on.

@oscargus
Copy link
Contributor

oscargus commented Mar 3, 2016

Looks good! Except that it won't work with nested aux-files...

Maybe it is time to move this to logic.auxparser and gui.auxdialog? (Or use the same naming in both packages.)

auxDatabase.insertEntry(clonedEntry);
}

/*
* Copy the database's configuration, i.e., preamble and strings.
*/
private void copyDatabaseConfiguration() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make sense to move the copyDatabaseConfiguration method to the BibDatabase class (since the db class knows best what to copy).

@tobiasdiez
Copy link
Member

Looks good to me.
One remark: I don't like that the parse method is invoked in the constructor. Maybe it is worthwhile to adopt the structure of the BibParser. There the parser has essentially one public method parse() which returns a ParseResult containing all the information.

@oscargus
Copy link
Contributor

oscargus commented Mar 5, 2016

👍 Anything to wait for or should we merge?

@tobiasdiez
Copy link
Member

👍

stefan-kolb added a commit that referenced this pull request Mar 5, 2016
Rework Aux dialog and logic
@stefan-kolb stefan-kolb merged commit 96fdf88 into master Mar 5, 2016
@stefan-kolb stefan-kolb deleted the aux-dialog branch March 5, 2016 16:46
@koppor koppor mentioned this pull request Sep 14, 2016
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants