-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Aux dialog and logic #900
Conversation
nestedAuxCounter = -1; // count only the nested reads | ||
private void parseAuxFile(String filename) { | ||
// nested aux files | ||
List<String> fileList = Arrays.asList(filename); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
asList(T... a)
Returns a fixed-size list backed by the specified array.
So it won't work to add file names later on.
Looks good! Except that it won't work with nested aux-files... Maybe it is time to move this to logic.auxparser and gui.auxdialog? (Or use the same naming in both packages.) |
auxDatabase.insertEntry(clonedEntry); | ||
} | ||
|
||
/* | ||
* Copy the database's configuration, i.e., preamble and strings. | ||
*/ | ||
private void copyDatabaseConfiguration() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would make sense to move the copyDatabaseConfiguration method to the BibDatabase class (since the db class knows best what to copy).
Looks good to me. |
👍 Anything to wait for or should we merge? |
👍 |
Rework Aux dialog and logic
No description provided.