-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: Move transport/display.go into bridge package #134
Labels
refactoring
Issues related to refactoring code.
Milestone
Comments
Actually: It might make more sense to move it into |
Jacalz
added a commit
that referenced
this issue
Jan 11, 2024
Jacalz
changed the title
internal: Move transport/display.go into ui package
internal: Move transport/display.go into bridge package
Jan 11, 2024
Jacalz
added a commit
that referenced
this issue
Jan 15, 2024
Jacalz
added a commit
that referenced
this issue
Jan 24, 2024
Jacalz
added a commit
that referenced
this issue
Jan 24, 2024
Jacalz
added a commit
that referenced
this issue
Mar 18, 2024
Jacalz
added a commit
that referenced
this issue
Mar 18, 2024
Jacalz
added a commit
that referenced
this issue
Apr 12, 2024
Jacalz
added a commit
that referenced
this issue
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Is your feature request related to a problem?
For some reason (probably due to how the old transport backend was put together), I placed the code for showing text send and receive windows in the
internal/transport
package as part of the client. This makes very little sense now that the coupling to the client struct is quite minimal.textSendWindow
intoui/send.go
.textRecvWindow
intoui/recv.go
.send
andrecv
structs instead of pointers (allocating the memory inline as much as possible.)Describe the solution you'd like to see.
Moving the sending code out of the
transport
package should not be too big of a deal. The receiving end might be a bit trickier.The text was updated successfully, but these errors were encountered: