Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Move transport/display.go into bridge package #134

Closed
4 of 5 tasks
Jacalz opened this issue Jan 11, 2024 · 1 comment
Closed
4 of 5 tasks

internal: Move transport/display.go into bridge package #134

Jacalz opened this issue Jan 11, 2024 · 1 comment
Labels
refactoring Issues related to refactoring code.
Milestone

Comments

@Jacalz
Copy link
Owner

Jacalz commented Jan 11, 2024

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

For some reason (probably due to how the old transport backend was put together), I placed the code for showing text send and receive windows in the internal/transport package as part of the client. This makes very little sense now that the coupling to the client struct is quite minimal.

  • Move textSendWindow into ui/send.go.
  • Move textRecvWindow into ui/recv.go.
  • Embed the types into the corresponding send and recv structs instead of pointers (allocating the memory inline as much as possible.)

Describe the solution you'd like to see.

Moving the sending code out of the transport package should not be too big of a deal. The receiving end might be a bit trickier.

@Jacalz Jacalz added the refactoring Issues related to refactoring code. label Jan 11, 2024
@Jacalz Jacalz added this to the v3.6.0 milestone Jan 11, 2024
@Jacalz
Copy link
Owner Author

Jacalz commented Jan 11, 2024

Actually: It might make more sense to move it into bridge.

Jacalz added a commit that referenced this issue Jan 11, 2024
@Jacalz Jacalz changed the title internal: Move transport/display.go into ui package internal: Move transport/display.go into bridge package Jan 11, 2024
@Jacalz Jacalz closed this as completed Jan 15, 2024
Jacalz added a commit that referenced this issue Jan 24, 2024
Jacalz added a commit that referenced this issue Mar 18, 2024
Jacalz added a commit that referenced this issue Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Issues related to refactoring code.
Projects
None yet
Development

No branches or pull requests

1 participant