Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use slider.OnChangeEnded API in Fyne v2.4.0 #79

Closed
2 tasks done
Jacalz opened this issue Apr 11, 2023 · 1 comment
Closed
2 tasks done

Use slider.OnChangeEnded API in Fyne v2.4.0 #79

Jacalz opened this issue Apr 11, 2023 · 1 comment
Labels
enhancement New feature or request
Milestone
v3.6.0

Comments

@Jacalz
Copy link
Owner

Jacalz commented Apr 11, 2023

Checklist

  • I have searched the issue tracker for open issues that relate to the same feature, before opening a new one.
  • This issue only relates to a single feature. I will open new issues for any other features.

Is your feature request related to a problem?

The slider calls a preference update on each drag. We should update the code to use the new API from fyne-io/fyne#3801 once we upgrade to Fyne v2.4.0.

Describe the solution you'd like to see.

Use the new API.
@Jacalz Jacalz added the enhancement New feature or request label Apr 11, 2023
@Jacalz Jacalz added this to the v3.5.0 milestone Apr 11, 2023
@Jacalz
Copy link
Owner Author

Jacalz commented Jun 8, 2023

Not needed. We need OnChanged to update the label.

@Jacalz Jacalz closed this as not planned Won't fix, can't repro, duplicate, stale Jun 8, 2023
@Jacalz Jacalz removed this from the v3.5.0 milestone Jun 8, 2023
@Jacalz Jacalz added this to the v3.6.0 milestone Nov 13, 2023
@Jacalz Jacalz reopened this Nov 13, 2023
Jacalz added a commit that referenced this issue Nov 13, 2023
@Jacalz
Only write component change when drag ends
0939d62 
Fixes #79
@Jacalz Jacalz closed this as completed Nov 13, 2023
Jacalz added a commit that referenced this issue Dec 29, 2023
@Jacalz
Only write component change when drag ends
452843b 
Fixes #79
Jacalz added a commit that referenced this issue Jan 24, 2024
@Jacalz
Only write component change when drag ends
b02869b 
Fixes #79
Jacalz added a commit that referenced this issue Mar 18, 2024
@Jacalz
Only write component change when drag ends
7c09bcf 
Fixes #79
Jacalz added a commit that referenced this issue Apr 12, 2024
@Jacalz
Only write component change when drag ends
bb2d73e 
Fixes #79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v3.6.0
Development

No branches or pull requests
1 participant
@Jacalz